Upgrading dependencies #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduced extra linting behaviour which was undesirable (re-sorting imports is too noisy in diffs, and anyway by being alphabetical it disrupts separations between external and internal imports) so the relevant rule has been switched off.
david-mears-2
commented
Dec 12, 2024
| @@ -40,7 +40,7 @@ | |||
| "hex-rgb": "^5.0.0", | |||
| "highcharts": "^11.4.8", | |||
| "lodash.throttle": "^4.1.1", | |||
| "nuxt": "^3.13.2", | |||
| "nuxt": "^3.14.1592", | |||
There was a problem hiding this comment.
They're doing a pi joke with their version numbers...
There was a problem hiding this comment.
not sure how i feel about this one 😆
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
=======================================
Coverage 37.15% 37.15%
=======================================
Files 56 56
Lines 146233 146233
Branches 371 371
=======================================
Hits 54334 54334
Misses 91883 91883
Partials 16 16 ☔ View full report in Codecov by Sentry. |
There were some 'critical' security vulns Updating out of caution even though dev dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade Nuxt minor version; run 'npm audit fix' - This introduced extra linting behaviour which was undesirable (re-sorting imports is too noisy in diffs, and anyway by being alphabetical it disrupts separations between external and internal imports) so the relevant rule has been switched off.