Skip to content

Commit

Permalink
move version info to about page
Browse files Browse the repository at this point in the history
  • Loading branch information
EmmaLRussell committed Oct 28, 2024
1 parent e3ba44e commit 50067b9
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 20 deletions.
4 changes: 0 additions & 4 deletions components/AppHeader.vue
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
data-testid="ji-logo-header"
style="width: 150px;"
class="img-fluid"
:title="versionTooltipContent"
src="~/assets/img/IMPERIAL_JAMEEL_INSTITUTE_LOCKUP-p-500.png"
alt="Imperial College and Community Jameel logo"
>
Expand All @@ -32,9 +31,6 @@
import { CIcon } from "@coreui/icons-vue";
import throttle from "lodash.throttle";
defineProps<{
versionTooltipContent: string | undefined
}>();
defineEmits<{
toggleSidebarVisibility: []
}>();
Expand Down
4 changes: 0 additions & 4 deletions components/SideBar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
<img
data-testid="ji-logo-sidebar"
class="img-fluid mb-1"
:title="versionTooltipContent"
src="~/assets/img/IMPERIAL_JAMEEL_INSTITUTE_LOCKUP-p-500.png"
alt="Imperial College and Community Jameel logo"
>
Expand All @@ -47,9 +46,6 @@
<script lang="ts" setup>
import { CIcon } from "@coreui/icons-vue";
defineProps<{
versionTooltipContent: string | undefined
}>();
const appStore = useAppStore();
const visible = defineModel("visible", { type: Boolean, required: true });
Expand Down
11 changes: 0 additions & 11 deletions layouts/default.vue
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,8 @@
<!-- <WebsocketConnection /> -->
<SideBar
v-model:visible="sidebarVisible"
:version-tooltip-content="versionTooltipContent"
/>
<AppHeader
:version-tooltip-content="versionTooltipContent"
@toggle-sidebar-visibility="handleToggleSidebarVisibility"
/>
<div class="wrapper d-flex flex-column">
Expand All @@ -30,15 +28,6 @@ function handleToggleSidebarVisibility() {
sidebarVisible.value = !sidebarVisible.value;
}
const versionTooltipContent = computed(() => {
const vers = appStore.versions;
if (vers) {
return `Model version: ${vers.daedalusModel} \nR API version: ${vers.daedalusApi} \nWeb app version: ${vers.daedalusWebApp}`;
} else {
return undefined;
}
});
const setScreenSize = () => {
const breakpoint = 992; // CoreUI's "lg" breakpoint
if (window.innerWidth < breakpoint) {
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "daedalus-web-app",
"type": "module",
"version": "0.0.2",
"version": "0.0.3",
"private": true,
"engines": {
"node": ">=20"
Expand Down
8 changes: 8 additions & 0 deletions pages/about.vue
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,14 @@
in Apache License via
<a href="https://www.svgrepo.com/" target="_blank">SVG Repo</a>
</p>
<template v-if="appStore.versions">
<h2>Version</h2>
<ul>
<li>Model version: {{ appStore.versions.daedalusModel }}</li>
<li>R API version: {{ appStore.versions.daedalusApi }}</li>
<li>Web app version: {{ appStore.versions.daedalusWebApp }}</li>
</ul>
</template>
<h2>References</h2>
<ol>
<li>
Expand Down

0 comments on commit 50067b9

Please sign in to comment.