Skip to content

Commit

Permalink
Fix Docker on CI issue
Browse files Browse the repository at this point in the history
  • Loading branch information
david-mears-2 committed Sep 3, 2024
1 parent 83228cd commit 0ee4b83
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
1 change: 1 addition & 0 deletions docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ ENV NODE_ENV=production
WORKDIR /src

COPY . .
RUN npm install -g npm@latest
RUN npm ci

# Generate the prisma client code
Expand Down
9 changes: 8 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
"vue": "latest"
},
"optionalDependencies": {
"@rollup/rollup-linux-x64-gnu": "4.21.1",
"bufferutil": "^4.0.8",
"utf-8-validate": "^6.0.4"
},
Expand Down Expand Up @@ -70,7 +71,13 @@
"0": "JSON doesn't support comments so I'm adding mine here.",
"1": "==============================",
"2": "Vue version is overridden because of the issue described in the 'tip' in",
"3": "the installation section of https://pinia.vuejs.org/ssr/nuxt.html"
"3": "the installation section of https://pinia.vuejs.org/ssr/nuxt.html",
"4": "==============================",
"5": "@rollup/rollup-linux-x64-gnu is an optional dependency as a fix for the issue that Rollup",
"6": "describes here: https://github.com/rollup/rollup/blob/f83b3151e93253a45f5b8ccb9ccb2e04214bc490/native.js#L59",
"7": "and which occurred for us when doing an installation with npm on Docker on CI. Their suggested fix",
"8": "does not work for our use case, because removing package-lock.json prevents the use of `npm ci`, so instead",
"9": "we use the solution suggested here: https://github.com/vitejs/vite/discussions/15532#discussioncomment-10192839"
},
"simple-git-hooks": {
"pre-commit": "npx lint-staged"
Expand Down

0 comments on commit 0ee4b83

Please sign in to comment.