Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add directives for accessing and remapping streams #174

Merged
merged 4 commits into from
Feb 5, 2023

Conversation

csnover
Copy link
Collaborator

@csnover csnover commented Nov 21, 2022

Initially I used reader/writer/map_reader/map_writer instead of just stream, but since a Read + Write + Seek is compatible with either, using stream/map_stream in the directive makes it possible to use #[brw] in some cases, where otherwise it would be impossible.

Unresolved questions:

  1. Should there be a try_map_stream too?
  2. Symmetry with Add helper attribute macros for writing free function parsers/writers #171: (a) in terms of putting the stream into the #[binread]/#[binwrite]/#[binrw] attribute instead of using a directive; (b) should Add helper attribute macros for writing free function parsers/writers #171 also just use the word stream instead of separating reader/writer?

@jam1garner jam1garner merged commit 98a1fb6 into jam1garner:master Feb 5, 2023
@csnover csnover deleted the dead-reckoning branch July 5, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants