Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

artifact exclude rules may exclude vendor files from deploy #69

Open
jonnsn opened this issue Nov 6, 2020 · 1 comment · Fixed by jonnsn/magento2-deployer-plus#1 · May be fixed by #70
Open

artifact exclude rules may exclude vendor files from deploy #69

jonnsn opened this issue Nov 6, 2020 · 1 comment · Fixed by jonnsn/magento2-deployer-plus#1 · May be fixed by #70

Comments

@jonnsn
Copy link

jonnsn commented Nov 6, 2020

file config/artifact.excludes contains the path "pub/media".
This will exclude every path where this pattern is contained.
E.g. the amasty module "product-attachment" contains this path
vendor/amasty/product-attachment/pub/media/amasty/...
which will be excluded too.
Solution is to use a leading slash, which is no absolute path but relative to the sync root folder.
The other paths are imo not critic.

@jonnsn
Copy link
Author

jonnsn commented Nov 6, 2020

sorry, I am not experienced with github PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant