feat: PHP 8.4

[dkarlovi]

Closes #506 506

[dkarlovi]

@jakzal do you have any idea why this build fails, it works for me locally. 🤔

[jakzal]

@dkarlovi the master branch build started failing couple days ago. Seems to be related to phpunit xsd not being available.

[dkarlovi]

@jakzal I've fixed that in this PR actually, my error is related to phive.

[jakzal]

@dkarlovi master is passing now, can you merge or rebase please? Some fixes I applied are similar to yours.

[dkarlovi]

Looking at this code and the one in devkit, we could extract the supported PHP versions from composer.json here instead of hardcoding it, probably also generate the Github actions YAML file.

[dkarlovi]

@jakzal done, but still the same Phive issue, I'm not sure what that's all about.

[dkarlovi]

Revisiting this, I have no idea what this is all about, could it be rat limits or something? It works on master, it works for me locally, it fails in this branch. 🤔

[dkarlovi]

@jakzal this seems to be due to GH rate limits, if you check the latest build, it says rate limit 60 which is definitely getting consumed by the previous steps, could your runs on master and in your branches somehow use your auth since you're the owner, but mine don't?

Edit: yep, seems that's it, I've updated the build step to use the user-specific secret, it means your pipelines will use your token and mine will use mine IIUC.

[dkarlovi]

@jakzal RFR.

[jakzal]

Thank you @dkarlovi 🍻