fix double writes

Signed-off-by: Jakub Dyszkiewicz <[email protected]>
jakubdyszkiewicz · Dec 4, 2023 · 164cceb · 164cceb
1 parent 670bd57
commit 164cceb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/pkg/core/managers/apis/dataplane/dataplane_manager.go b/pkg/core/managers/apis/dataplane/dataplane_manager.go
@@ -114,6 +114,10 @@ func (m *dataplaneManager) setHealth(dp *core_mesh.DataplaneResource) {
 	for _, inbound := range dp.Spec.Networking.Inbound {
 		if inbound.ServiceProbe != nil {
 			inbound.State = mesh_proto.Dataplane_Networking_Inbound_NOT_READY
+			// write health for backwards compatibility with Kuma 2.5 and older
+			inbound.Health = &mesh_proto.Dataplane_Networking_Inbound_Health{
+				Ready: false,
+			}
 		}
 	}
 }
diff --git a/pkg/hds/tracker/callbacks.go b/pkg/hds/tracker/callbacks.go
@@ -221,7 +221,7 @@ func (t *tracker) updateDataplane(streamID xds.StreamID, healthMap map[uint32]bo
 			inbound.Health = &mesh_proto.Dataplane_Networking_Inbound_Health{
 				Ready: false,
 			}
-			changed = false
+			changed = true
 		}
 	}