Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ON HOLD] Enable passing through the requests to the original URL v2 #233

Closed
wants to merge 4 commits into from

Conversation

prantlf
Copy link
Contributor

@prantlf prantlf commented Mar 16, 2015

If passThrough is true, performs the request with the original settings and lets the onAfter[x] callback modify the response:

$.mockjax({
  url: '/api/currentuser',
  passThrough: true,
  onAfterSuccess: function (response) {
    response.image = '/images/profile';
  }
});

This suggest a resolution for the second half of the #225.

@jakerella
Copy link
Owner

@dcneiner Can you review this one as well?

@prantlf Same as the other PR, looks like some small conflicts crept in. Can you resolve?

@dcneiner
Copy link
Collaborator

@prantlf @jakerella Please see my comments on #232, as that will impact this PR some. I think this PR looks good, though I'd recommend renaming the function variable passThroughCallbacks to something that reflects its more generic usage. Perhaps wrapCallbacks or something you like better.

Thanks again for your work on this!

@jakerella
Copy link
Owner

On hold until conflicts can be resolved.

@jakerella jakerella changed the title Enable passing through the requests to the original URL v2 [ON HOLD] Enable passing through the requests to the original URL v2 Dec 20, 2015
@jakerella
Copy link
Owner

Closing this PR for inactivity. The issue is still there, and the code is on a good path. Any new PR would need to be merged into master at this point.

@jakerella jakerella closed this Jan 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants