Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TCK Challenge] check for object identity in dispatcher test #524

Closed
janbartel opened this issue Apr 12, 2023 · 2 comments
Closed

[TCK Challenge] check for object identity in dispatcher test #524

janbartel opened this issue Apr 12, 2023 · 2 comments
Labels
TCK:accepted TCK challenge accepted TCK:challenge TCK challenge

Comments

@janbartel
Copy link
Contributor

Challenged tests:

com/sun/ts/tests/servlet/spec/requestdispatcher/URLClient.requestDispatcherNoWrappingTest

TCK Version:

servlet-tck-6.0.1

Tested Implementation:

Jetty

Description:

Version 6 of the Servlet Spec removed the requirement for object identity during dispatch, see #411. However, the above test is still included in the tck.
@markt-asf markt-asf added the TCK:challenge TCK challenge label Apr 12, 2023
@markt-asf
Copy link
Contributor

Looks reasonable to me. I'll leave it a little while to allow others to comment but my expectation at this point is that:

  • the challenge will be accepted
  • the test can be added to the ignore list for now
  • the test will be removed for the Servlet 6.1 TCK

@stuartwdouglas
Copy link
Contributor

Seems reasonable to me.

@markt-asf markt-asf added the TCK:accepted TCK challenge accepted label Mar 22, 2024
markt-asf added a commit to markt-asf/servlet-api that referenced this issue Mar 22, 2024
@markt-asf
Fix jakartaee#524 - TCK challenge - remove test that no longer applies
8a88a6c 
The require this test checks has been removed from the Servlet spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
TCK:accepted TCK challenge accepted TCK:challenge TCK challenge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stuartwdouglas @janbartel @markt-asf