-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic module name #92
Conversation
Signed-off-by: Guillermo González de Agüero <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I doubt if we ever will be allowed to use the java prefix for module names from Oracle.
We need to wait with this (since we should never change this module name in the future) until there is an agreement around package names and module names between Oracle and Eclipse Foundation.
Based on @bshannon comments on jakartaee/servlet#204 (comment) and jakartaee/common-annotations-api#6 (review) I don't think we need to wait until the agreement to merge, and I understand that we could even integrate this into the first release, since it doesn't chance the API. I will have to ask the later to be completely sure. |
Do note that there's the first release from the master branch, and the first release from the EE4J_8 branch. The upcoming mandatory EE4J_8 release is the one that can't have API changes. |
Would this considered an API change? It definitely changes some behaviour |
@rdebusscher what is your vote on this issue? I'd like to resolve this one by either merging it as-is, or closing it if you vote -1, but I do need to know ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, we can put it in as proposed. But should come back to this name once there is an official statement about module names.
@rdebusscher okay, thx! |
This is a first step before true modularization. We still depend on some projects which don't provide module names so I don't think we can go further right now.