Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[853] Deprecate Link JAXB inner classes #919

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

andymc12
Copy link
Contributor

Deprecates the JAXB inner classes in the Link class, and modifies the example code use JSON instead of XML so as to avoid any dependencies on JAXB / Jakarta XML Binding.

This closes #853.

@andymc12 andymc12 self-assigned this Nov 10, 2020
spericas
spericas previously approved these changes Nov 10, 2020
Copy link
Contributor

@spericas spericas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels good to approve this one!

mkarg
mkarg previously approved these changes Nov 10, 2020
chkal
chkal previously approved these changes Nov 11, 2020
@andymc12 andymc12 changed the base branch from 3.1-SNAPSHOT to master November 12, 2020 18:02
@andymc12 andymc12 dismissed stale reviews from chkal, mkarg, and spericas November 12, 2020 18:02

The base branch was changed.

@andymc12
Copy link
Contributor Author

Hmm... the force push ended up pulling in several other commits unrelated to this PR. Now that 3.0.0 is released, should I be making this change in 3.1-SNAPSHOT or master? The intent is for it to be in 3.1, but I was thinking that master was retargeted for the 3.1 release. This is a small change, so if it makes sense for me to just open up a new/clean PR I can do that - but which branch should I base it on? Thanks

@mkarg
Copy link
Contributor

mkarg commented Nov 12, 2020

Hmm... the force push ended up pulling in several other commits unrelated to this PR. Now that 3.0.0 is released, should I be making this change in 3.1-SNAPSHOT or master? The intent is for it to be in 3.1, but I was thinking that master was retargeted for the 3.1 release. This is a small change, so if it makes sense for me to just open up a new/clean PR I can do that - but which branch should I base it on? Thanks

Just wait a bit. I am in the middle of putting 3.1-SNAPSHOT ontop master but got stuck due to a build fail last night on JDK 14+. Once that is solved and merged, just rebase this PR's source branch ontop master then. This will remove the unwanted commits.

@andymc12
Copy link
Contributor Author

@mkarg sounds good. I did rebase the PR from 3.1-SNAPSHOT to master which removed the approvals. So once you've got master the way we want it, I'll ask you all to re-approve. Thanks

@mkarg
Copy link
Contributor

mkarg commented Nov 13, 2020

Just waiting for your approval of #920. :-)

@mkarg
Copy link
Contributor

mkarg commented Nov 14, 2020

@andymc12 Can you now please rebase on master and then force-push with the same branch name? Thanks! :-)

@mkarg mkarg added this to the 3.1 milestone Nov 14, 2020
@andymc12 andymc12 force-pushed the 853-deprecateJaxbUsage branch from 73758c7 to 9e0bda5 Compare November 14, 2020 14:55
@andymc12
Copy link
Contributor Author

All set - now it is rebased on master (which is targeting the 3.1 release). @chkal @mkarg @spericas could you please re-approve? Thanks!

Copy link
Contributor

@chkal chkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andymc12

@andymc12 andymc12 merged commit 42d3e46 into jakartaee:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate JAXB usage in Link class.
4 participants