-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[853] Deprecate Link JAXB inner classes #919
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels good to approve this one!
The base branch was changed.
Hmm... the force push ended up pulling in several other commits unrelated to this PR. Now that 3.0.0 is released, should I be making this change in 3.1-SNAPSHOT or master? The intent is for it to be in 3.1, but I was thinking that master was retargeted for the 3.1 release. This is a small change, so if it makes sense for me to just open up a new/clean PR I can do that - but which branch should I base it on? Thanks |
Just wait a bit. I am in the middle of putting 3.1-SNAPSHOT ontop master but got stuck due to a build fail last night on JDK 14+. Once that is solved and merged, just rebase this PR's source branch ontop master then. This will remove the unwanted commits. |
@mkarg sounds good. I did rebase the PR from 3.1-SNAPSHOT to master which removed the approvals. So once you've got master the way we want it, I'll ask you all to re-approve. Thanks |
Just waiting for your approval of #920. :-) |
@andymc12 Can you now please rebase on |
Signed-off-by: Andy McCright <[email protected]>
73758c7
to
9e0bda5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andymc12
Deprecates the JAXB inner classes in the Link class, and modifies the example code use JSON instead of XML so as to avoid any dependencies on JAXB / Jakarta XML Binding.
This closes #853.