Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore the EL javatest based branch , move EL standalone tck module to el-tck #1425

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

alwin-joseph
Copy link
Contributor

@alwin-joseph alwin-joseph commented Jul 28, 2024

Related Issue(s)
#1380

Describe the change

  • Move the current refactored EL standalone tck module to el-tck (This source was used to release EL TCK 6.0.0 and 6.0.1 versions for EE11)
  • Restore the el module based on the javatest classes to be run for platform. The new tests and the test related changes made in standalone el-tck EE11 are copied to the el/ EE module. This is needed to be able to update the EL platform tests using the tools tck-rewrite effort to run in servlet and jsp vehicles.

This will essentially create 2 sources of truth for EL tests - one for standalone and another for platform in EE11 - similar to the jms changes in #1395.

cc @scottmarlow @starksm64 @gurunrao

@scottmarlow
Copy link
Contributor

@arjantijms please approve this change after reading the description. I would like to see your approval since you are the lead of the Expression Language specification.

@arjantijms
Copy link
Contributor

@scottmarlow looks good, thanks!

@scottmarlow
Copy link
Contributor

scottmarlow commented Aug 1, 2024

@scottmarlow looks good, thanks!

@arjantijms just one more point that may not be obvious to all. The component/standalone folder el-tck will retain all prior (Jakarta EE 8 - now) EL TCK commits but the new el folder history will start from this pull request.

The el tests will extend com.sun.ts.lib.harness.ServiceEETest. If we could made the el tests extend both com.sun.ts.lib.harness.ServiceEETest and the component el-tck test class, we would NOT need this fork.

@scottmarlow
Copy link
Contributor

The el tests will extend com.sun.ts.lib.harness.ServiceEETest. If we could made the el tests extend both com.sun.ts.lib.harness.ServiceEETest and the component el-tck test class, we would NOT need this fork.

I have some ideas for instead using delegation but we are trying to meet a deadline for EE 11...

@scottmarlow scottmarlow merged commit 6ed8e72 into jakartaee:main Aug 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants