Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify that @JsonbNumberFormat is depending on the Locale #362

Open
struberg opened this issue Oct 20, 2024 · 1 comment · May be fixed by #363
Open

clarify that @JsonbNumberFormat is depending on the Locale #362

struberg opened this issue Oct 20, 2024 · 1 comment · May be fixed by #363

Comments

@struberg
Copy link

When defining a custom pattern in @JsonbNumberFormat you still end up with a Locale depending and thus non-portable JSON.

This should be pointed out in the JavaDoc.
struberg added a commit to struberg/jsonb-api that referenced this issue Oct 20, 2024
@struberg
fixes: jakartaee#362 Locale problem with JsonbNumberFormat
16b1911
@jungm
Copy link

jungm commented Oct 20, 2024 •
edited
Loading

IMO it should not just be pointed out in the docs (one could easily miss this) but instead a locale must be defined when you use @JsonbNumberFormat

This is of course a breaking change though :/

struberg added a commit to struberg/jsonb-api that referenced this issue Oct 28, 2024
@struberg
fixes: jakartaee#362 Locale with JsonbNumberFormat
272d158 
improvements in wording, copyright updated and unnecessary import removed.
@Verdent Verdent linked a pull request Nov 13, 2024 that will close this issue
fixes: #362 Locale problem with JsonbNumberFormat #363
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes: #362 Locale problem with JsonbNumberFormat struberg/jsonb-api
2 participants
@struberg @jungm