Allow FactoryFinder to try to load class with jakarta api class's cla… #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lukasj Can you please review ? |
|
@jimma It looks like the JavaDoc year needs to be updated as there is a validation failure for that. That said this fix looks okay to me. |
jimma
force-pushed
the
factory-finder-issue
branch
2 times, most recently
from
ce4a74c
to
5f3187f
Compare
jimma
force-pushed
the
factory-finder-issue
branch
from
5f3187f
to
95378d0
Compare
|
@jamezp Thanks for review, James ! Already fixed this copyright year issue. |
|
@lukasj Can you please review this PR ? |
lukasj
reviewed
Oct 5, 2022
| @@ -1,7 +1,7 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <!-- | |||
|
|
|||
| Copyright (c) 1997, 2021 Oracle and/or its affiliates. All rights reserved. | |||
| Copyright (c) 1997, 2022 Oracle and/or its affiliates. All rights reserved. | |||
There was a problem hiding this comment.
these changes were not needed as the gh build action failure is caused by the way the PR build works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ssloader