Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StepSecurity] Apply security best practices #113

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

step-security-bot
Copy link

Summary

This pull request is created by Secure Repo at the request of @fperezel. Please merge the Pull Request to incorporate the requested changes. Please tag @fperezel on your message if you have any questions related to the PR. You can also engage with the StepSecurity team by tagging @step-security-bot.

Security Fixes

resolve: #112

Keeping your actions up to date with Dependabot

With Dependabot version updates, when Dependabot identifies an outdated dependency, it raises a pull request to update the manifest to the latest version of the dependency. This is recommended by GitHub as well as The Open Source Security Foundation (OpenSSF).

Feedback

For bug reports, feature requests, and general feedback; please create an issue in step-security/secure-repo. To create such PRs, please visit https://app.stepsecurity.io/securerepo.

Signed-off-by: StepSecurity Bot [email protected]

Copy link
Contributor

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasj
Copy link
Contributor

lukasj commented Jun 6, 2023

@fperezel yaml file allows comment - is there any reason to not include license header in this file?

@ghost
Copy link

ghost commented Jun 6, 2023

@fperezel yaml file allows comment - is there any reason to not include license header in this file?

Hi @lukasj ,

The file is generated based on a template thus by default it doesn't include comments about license header. Besides, this is a github files to configure dependabot. So I am wondering which type of incense should include.

Can you tell me more about which license should be added and provide me an example?

Thanks,

@lukasj
Copy link
Contributor

lukasj commented Jun 6, 2023

@fperezel I usually add the license the project itself is said to use, so in this particular case it should be an EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0, see ie the project pom for the text; an example with different license is ie here

@ghost
Copy link

ghost commented Jun 6, 2023

@fperezel I usually add the license the project itself is said to use, so in this particular case it should be an EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0, see ie the project pom for the text; an example with different license is ie here

Hi @lukasj

Thanks for the example and I have already update the PR

Please, don't hesitate and let me know if there is something more needed.

Thanks

@@ -0,0 +1,24 @@
#
# Copyright (c) 2021, 2022 Contributors to the Eclipse Foundation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new file, so the year should be just 2023

# or the Eclipse Distribution License v. 1.0 which is available at
# http://www.eclipse.org/org/documents/edl-v10.php.
#
# SPDX-License-Identifier: EPL-2.0 OR BSD-3-Clause
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this project uses EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0, the text is ie here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security Best Practices
2 participants