Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A manually set configuredProvider can be lost for good. #461

Closed
benjamin-confino opened this issue Dec 17, 2020 · 1 comment
Closed

A manually set configuredProvider can be lost for good. #461

benjamin-confino opened this issue Dec 17, 2020 · 1 comment

Comments

@benjamin-confino
Copy link
Contributor

The changes made in #445 means that a manually set configuredProvider can be lost for good if it ever returns null and it is registered in the ServiceLoader.
@benjamin-confino benjamin-confino mentioned this issue Dec 17, 2020
Merged
benjamin-confino added a commit to benjamin-confino/open-liberty that referenced this issue Dec 21, 2020
@benjamin-confino
Adds a service loader reference to CDIRuntimeImpl (which implements C…
f89f9f7 
…DIProvider)

This is a workaround for jakartaee/cdi#461. Because
of that bug CDI.java will clear the CDIProvider set in AbstractCDIRuntime.start()
if CDIProvider.getCDI() ever returns null and later attempt to reacquire it
through the service loader.

CDIProvider.getCDI() will return null if ever called from the context of a non
CDI app
@manovotn
Copy link
Contributor

Fixed by #462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@manovotn @benjamin-confino