Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft of new Image updater proposal - updated application CRD #1

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

jaideepr97
Copy link
Owner

Signed-off-by: Jaideep Rao [email protected]

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2022

Codecov Report

Base: 47.30% // Head: 47.30% // No change to project coverage 👍

Coverage data is based on head (3d218ef) compared to base (a50a67e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master       #1   +/-   ##
=======================================
  Coverage   47.30%   47.30%           
=======================================
  Files         243      243           
  Lines       41525    41525           
=======================================
  Hits        19644    19644           
  Misses      19907    19907           
  Partials     1974     1974           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of nits and some questions :)

docs/proposals/image-updater-first-class-support.md Outdated Show resolved Hide resolved
docs/proposals/image-updater-first-class-support.md Outdated Show resolved Hide resolved
docs/proposals/image-updater-first-class-support.md Outdated Show resolved Hide resolved
docs/proposals/image-updater-first-class-support.md Outdated Show resolved Hide resolved
docs/proposals/image-updater-first-class-support.md Outdated Show resolved Hide resolved
docs/proposals/image-updater-first-class-support.md Outdated Show resolved Hide resolved
docs/proposals/image-updater-first-class-support.md Outdated Show resolved Hide resolved
docs/proposals/image-updater-first-class-support.md Outdated Show resolved Hide resolved
docs/proposals/image-updater-first-class-support.md Outdated Show resolved Hide resolved
docs/proposals/image-updater-first-class-support.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants