Skip to content

Commit

Permalink
Fix WASAPI option enabling/disabling when restoring advanced options (n…
Browse files Browse the repository at this point in the history
…vaccess#15355)

Summary of the issue:
The following advanced options are greyed out or not depending if they are applicable: "Volume of NVDA sounds" and "Volume of NVDA sounds follows voice volume". If they are applicable or not depends on other options: "Use WASAPI for audio output" and "Volume of NVDA sounds" respectively. Unfortunately, when pressing the "Restore defaults" button of the advanced panel, the options are reset to there default values, but they are not greyed out / ungreyed accordingly.

Description of user facing changes
When pressing the restore default button in advanced panel, WASAPI advanced options will now be greyed out or not according to if they are applicable or not.

Description of development approach
Just call the update function self._onWASAPIChange() when restoring the values.
  • Loading branch information
CyrilleB79 authored Sep 3, 2023
1 parent 128f683 commit 404e316
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions source/gui/settingsDialogs.py
Original file line number Diff line number Diff line change
Expand Up @@ -3233,6 +3233,7 @@ def restoreToDefaults(self):
self.wasapiComboBox.resetToConfigSpecDefault()
self.soundVolFollowCheckBox.SetValue(self.soundVolFollowCheckBox.defaultValue)
self.soundVolSlider.SetValue(self.soundVolSlider.defaultValue)
self._onWASAPIChange()
self.logCategoriesList.CheckedItems = self.logCategoriesList.defaultCheckedItems
self.playErrorSoundCombo.SetSelection(self.playErrorSoundCombo.defaultValue)
self._defaultsRestored = True
Expand Down

0 comments on commit 404e316

Please sign in to comment.