Skip to content

Commit

Permalink
Merge pull request graphql-python#154 from CaselIT/logging
Browse files Browse the repository at this point in the history
Replaced sys.excepthook with logging.error
  • Loading branch information
syrusakbary authored Jan 21, 2018
2 parents 6df8a63 + a3ba849 commit 6a55133
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions graphql/execution/base.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# -*- coding: utf-8 -*-
import sys
import logging
from traceback import format_exception

from ..error import GraphQLError
from ..language import ast
Expand All @@ -11,6 +12,8 @@
from ..utils.type_from_ast import type_from_ast
from .values import get_argument_values, get_variable_values

logger = logging.getLogger(__name__)


class ExecutionContext(object):
"""Data that must be available at all points during query execution.
Expand Down Expand Up @@ -87,8 +90,8 @@ def get_argument_values(self, field_def, field_ast):
return result

def report_error(self, error, traceback=None):
sys.excepthook(type(error), error, getattr(
error, 'stack', None) or traceback)
exception = format_exception(type(error), error, getattr(error, 'stack', None) or traceback)
logger.error(''.join(exception))
self.errors.append(error)

def get_sub_fields(self, return_type, field_asts):
Expand Down

0 comments on commit 6a55133

Please sign in to comment.