WIP: Sample gRPC server #903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
requested review from
black-adder,
jpkrohling,
pavolloffay and
vprithvi
as code owners
ghost
assigned 
jpkrohling
reviewed
Jul 2, 2018
| // grpc.UnaryInterceptor(grpc_validator.UnaryServerInterceptor()), | ||
| // grpc.StreamInterceptor(grpc_validator.StreamServerInterceptor()), | ||
| ) | ||
| api_v2.RegisterQueryServiceServer(s, server.New()) |
There was a problem hiding this comment.
Just wanted to mention that it's probably a good idea to have each service on its own port, so that different components can have different constraints. Like, I might want to expose the Query Service to the public internet but not the Collector.
Codecov Report
@@ Coverage Diff @@
## master #903 +/- ##
==========================================
- Coverage 100% 99.67% -0.33%
==========================================
Files 138 140 +2
Lines 6373 6424 +51
==========================================
+ Hits 6373 6403 +30
- Misses 0 21 +21
Continue to review full report at Codecov.
|
yurishkuro
force-pushed
the
grpc
branch
3 times, most recently
from
95a3a81
to
426d31b
Compare
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Jan Heylen <[email protected]>
* Fix test error Signed-off-by: Isaac Hier <[email protected]> * go fmt Signed-off-by: Isaac Hier <[email protected]>
|
done in #1165 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocked on #927