Add ability to adjust static sampling probabilities per operation #827
Conversation
Signed-off-by: Won Jun Jang <[email protected]>
black-adder
requested review from
pavolloffay,
vprithvi and
yurishkuro
as code owners
| @@ -81,7 +81,7 @@ def main(): | |||
| for f in go_files: | |||
| parsed, imports_reordered = parse_go_file(f) | |||
| if output == "stdout" and imports_reordered: | |||
| print f + " imports out of order" | |||
| print(f + " imports out of order") | |||
There was a problem hiding this comment.
i somehow got python 3 installed on my machine and this is backwards compatible with python 2 anyway
| @@ -21,9 +21,16 @@ type strategy struct { | |||
| Param float64 `json:"param"` | |||
| } | |||
|
|
|||
| // operationStrategy defines a operation specific sampling strategy. | |||
|
is there an issue that should be linked to this PR? |
Signed-off-by: Won Jun Jang <[email protected]>
|
Not necessarily in scope for this PR, but I think we will also eventually need to take into account tags - for example, depending upon the instrumentation used, we may get a span reported with Reason for raising here is more to do with how the strategy is modeled - it now includes "operation_strategies" - possibly want to make this more generic so could in the future be based on operation and/or a set of tags? |
|
@objectiser we've always shied away from trying to infer operation name from the URL, due to REST practice of encoding IDs into the path. The recommendation is to fix the instrumentation to use route as the span name, instead of the http method. |
ghost
assigned * master: (38 commits) Preparing release 1.5.0 (jaegertracing#847) Add bounds to memory storage (jaegertracing#845) Add metric for debug traces (jaegertracing#796) Change metrics naming scheme (jaegertracing#776) Bump gocql version (jaegertracing#829) Remove ParentSpanID from domain model (jaegertracing#831) Make gas run quiet (jaegertracing#838) Revert "Make gas run quite" Revert "Install gas from install-ci" Install gas from install-ci Make gas run quite Add 'gas' for security problems scanning (jaegertracing#830) Add ability to adjust static sampling probabilities per operation (jaegertracing#827) Support log-level flag on agent (jaegertracing#828) Remove unused function (jaegertracing#822) Add healthcheck to standalone (jaegertracing#784) Do not use KeyValue fields directly and use KeyValues as decorator only (jaegertracing#810) Add ContaAzul to the adopters list (jaegertracing#806) Add ISSUE_TEMPLATE and PULL_REQUEST_TEMPLATE (jaegertracing#805) Upgrade to go 1.10 (jaegertracing#792) ... # Conflicts: # cmd/agent/app/builder.go # cmd/collector/main.go # cmd/query/main.go # cmd/standalone/main.go
Signed-off-by: Won Jun Jang [email protected]
Which problem is this PR solving?
Short description of the changes