Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LeveledMeterProvider to telemetry setting #6173

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chahatsagarmain
Copy link
Contributor

Which problem is this PR solving?

How was this change tested?

  • make lint test

Checklist

Signed-off-by: chahatsagarmain <[email protected]>
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.47%. Comparing base (0a24f6d) to head (3a1a4f7).

Files with missing lines Patch % Lines
...md/jaeger/internal/extension/jaegerquery/server.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6173   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files         354      354           
  Lines       20126    20133    +7     
=======================================
+ Hits        19417    19424    +7     
  Misses        524      524           
  Partials      185      185           
Flag Coverage Δ
badger_v1 8.31% <ø> (ø)
badger_v2 1.67% <ø> (ø)
cassandra-4.x-v1 14.39% <ø> (ø)
cassandra-4.x-v2 1.61% <ø> (ø)
cassandra-5.x-v1 14.39% <ø> (ø)
cassandra-5.x-v2 1.61% <ø> (ø)
elasticsearch-6.x-v1 18.59% <ø> (-0.01%) ⬇️
elasticsearch-7.x-v1 18.67% <ø> (-0.01%) ⬇️
elasticsearch-8.x-v1 18.84% <ø> (-0.01%) ⬇️
elasticsearch-8.x-v2 1.66% <ø> (-0.02%) ⬇️
grpc_v1 9.48% <ø> (ø)
grpc_v2 7.00% <ø> (+<0.01%) ⬆️
kafka-v1 8.88% <ø> (ø)
kafka-v2 1.67% <ø> (ø)
memory_v2 1.67% <ø> (ø)
opensearch-1.x-v1 18.73% <ø> (ø)
opensearch-2.x-v1 18.73% <ø> (ø)
opensearch-2.x-v2 1.66% <ø> (-0.02%) ⬇️
tailsampling-processor 0.46% <ø> (ø)
unittests 95.39% <76.92%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chahatsagarmain
Copy link
Contributor Author

@mahadzaryab1 how will i propogate leveledmeterprovider where telset is not part of function arguement ? Do i just use noop meterprovider there ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[jaeger-v2] Add Meter Provider To Telemetry Settings
1 participant