Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use Contains or ErrorContains with testify #6161

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Nov 4, 2024

Description of the changes

  • use Contains or ErrorContains with testify
  • remove useless Error check before ErrorContains check

How was this change tested?

  • CI

Checklist

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.49%. Comparing base (1378e91) to head (eafd0e1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6161   +/-   ##
=======================================
  Coverage   96.49%   96.49%           
=======================================
  Files         354      354           
  Lines       20126    20126           
=======================================
  Hits        19420    19420           
  Misses        522      522           
  Partials      184      184           
Flag Coverage Δ
badger_v1 8.31% <ø> (ø)
badger_v2 1.67% <ø> (ø)
cassandra-4.x-v1 14.39% <ø> (ø)
cassandra-4.x-v2 1.61% <ø> (ø)
cassandra-5.x-v1 14.39% <ø> (ø)
cassandra-5.x-v2 1.61% <ø> (ø)
elasticsearch-6.x-v1 18.59% <ø> (-0.01%) ⬇️
elasticsearch-7.x-v1 18.68% <ø> (+<0.01%) ⬆️
elasticsearch-8.x-v1 18.85% <ø> (ø)
elasticsearch-8.x-v2 1.67% <ø> (+0.01%) ⬆️
grpc_v1 9.48% <ø> (ø)
grpc_v2 6.99% <ø> (-0.01%) ⬇️
kafka-v1 8.88% <ø> (ø)
kafka-v2 1.67% <ø> (?)
memory_v2 1.67% <ø> (ø)
opensearch-1.x-v1 18.72% <ø> (ø)
opensearch-2.x-v1 18.72% <ø> (ø)
opensearch-2.x-v2 1.67% <ø> (ø)
tailsampling-processor 0.46% <ø> (ø)
unittests 95.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmorel-35 mmorel-35 force-pushed the golangci-lint/contains branch 5 times, most recently from 00eaba7 to ea1adc3 Compare November 4, 2024 21:49
@mmorel-35 mmorel-35 marked this pull request as ready for review November 4, 2024 21:50
@mmorel-35 mmorel-35 requested a review from a team as a code owner November 4, 2024 21:50
@yurishkuro yurishkuro added the changelog:test Change that's adding missing tests or correcting existing tests label Nov 4, 2024
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is a massive clean up 🤩

many thanks 🙏 🚀

@yurishkuro yurishkuro merged commit 74ec19a into jaegertracing:main Nov 4, 2024
50 of 51 checks passed
@mmorel-35 mmorel-35 deleted the golangci-lint/contains branch November 4, 2024 22:39
@mmorel-35 mmorel-35 restored the golangci-lint/contains branch November 4, 2024 22:39
@mmorel-35 mmorel-35 deleted the golangci-lint/contains branch November 4, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:test Change that's adding missing tests or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants