chore: enable err-error and errorf rules from perfsprint linter #6160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @ChengenH |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6160 +/- ##
==========================================
+ Coverage 96.47% 96.49% +0.01%
==========================================
Files 354 354
Lines 20126 20126
==========================================
+ Hits 19417 19420 +3
+ Misses 524 522 -2
+ Partials 185 184 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
force-pushed
the
golangci-lint/perfsprint
branch
from
79ccbfe
to
410bdda
Compare
yurishkuro
approved these changes
Nov 4, 2024
| "testing" | ||
|
|
||
| "github.com/olivere/elastic" | ||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestDetailedError(t *testing.T) { | ||
| require.ErrorContains(t, fmt.Errorf("some err"), "some err", "no panic") | ||
| require.ErrorContains(t, errors.New("some err"), "some err", "no panic") |
There was a problem hiding this comment.
No idea what this is trying to do
There was a problem hiding this comment.
Maybe testing testify. I don’t see any other reason yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
err-erroranderrorfrules from perfsprint lintererrors.Newinstead offmt.Errorfwhen there is only one argumentHow was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test