Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix es integration test 6094 #6157

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix es integration test 6094 #6157

wants to merge 3 commits into from

Conversation

madmecodes
Copy link

This change fixes two issues in ES integration tests:

  1. Prevents index not found exceptions by proper index readiness checks
  2. Prevents duplicate span detection issues

The solution uses sync.Map for thread-safe:

  • Index existence caching
  • Span tracking

Fixes #6094

Which problem is this PR solving?

  • Resolves ES 8.x / v2 integration test often fails #6094
  • Fixes race conditions in ES integration tests where:
    • Index not found exceptions occur ~170ms after index creation
    • Duplicate spans are incorrectly detected (10 spans reduced to 5)

Description of the changes

  • Added thread-safe index readiness verification
    • Using sync.Map for index caching
    • Added proper index existence checks
    • Added wait/retry logic for index readiness
  • Fixed duplicate span detection
    • Added thread-safe span tracking using sync.Map
    • Improved logging around span operations

How was this change tested?

  • Ran ES integration tests multiple times with results:

@madmecodes
Fix ES integration test race conditions
50eeed3 
This change fixes two issues in ES integration tests:
1. Prevents index not found exceptions by proper index readiness checks
2. Prevents duplicate span detection issues

The solution uses sync.Map for thread-safe:
- Index existence caching
- Span tracking

Fixes jaegertracing#6094

Signed-off-by: ayush-gupta-dev <[email protected]>
@madmecodes
Fix ES integration test race conditions
8af7455 
This change fixes two issues in ES integration tests:
1. Prevents index not found exceptions by proper index readiness checks
2. Prevents duplicate span detection issues

The solution uses sync.Map for thread-safe:
- Index existence caching
- Span tracking

Fixes jaegertracing#6094

Signed-off-by: ayush-gupta-dev <[email protected]>
@madmecodes madmecodes requested a review from a team as a code owner November 3, 2024 20:45
@madmecodes madmecodes mentioned this pull request Nov 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkowall jkowall Awaiting requested review from jkowall jkowall is a code owner automatically assigned from jaegertracing/jaeger-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug storage/elasticsearch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ES 8.x / v2 integration test often fails
1 participant
@madmecodes