Fix command in v2 example #6134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `component.UseLocalHostAsDefaultHost` gate has been removed from otel collector since v0.112.0. Set endpoints for otlpreceiver explicitly. Signed-off-by: haoqixu <[email protected]>
yurishkuro
approved these changes
Oct 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6134 +/- ##
==========================================
+ Coverage 96.21% 96.43% +0.22%
==========================================
Files 353 353
Lines 20135 20135
==========================================
+ Hits 19372 19417 +45
+ Misses 580 533 -47
- Partials 183 185 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Insomniac2904
pushed a commit
to Insomniac2904/jaeger
that referenced
this pull request
Oct 29, 2024
## Which problem is this PR solving? The `component.UseLocalHostAsDefaultHost` gate has been removed from otel collector since v0.112.0. The example failed to start `jaeger` because of the invalid argument. ## Description of the changes - Remove the invalid command line argument. - Set endpoints for `otlpreceiver` explicitly. ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: haoqixu <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> Signed-off-by: Insomniac2904 <[email protected]>
yurishkuro
added a commit
to yurishkuro/jaeger
that referenced
this pull request
Nov 2, 2024
This reverts commit e327edb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
The
component.UseLocalHostAsDefaultHostgate has been removed from otel collector since v0.112.0. The example failed to startjaegerbecause of the invalid argument.Description of the changes
otlpreceiverexplicitly.Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test