Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query][test] Add unit test for tracing http requests in query server #6131

Merged
merged 3 commits into from
Oct 27, 2024

Conversation

mahadzaryab1
Copy link
Collaborator

Which problem is this PR solving?

Description of the changes

  • Added a unit test for tracing http request endpoints in query server

How was this change tested?

  • CI

Checklist

@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner October 27, 2024 19:46
Signed-off-by: Mahad Zaryab <[email protected]>
@mahadzaryab1 mahadzaryab1 added the changelog:test Change that's adding missing tests or correcting existing tests label Oct 27, 2024
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.41%. Comparing base (f0c5a1d) to head (06aab81).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6131      +/-   ##
==========================================
- Coverage   96.43%   96.41%   -0.02%     
==========================================
  Files         353      353              
  Lines       20135    20135              
==========================================
- Hits        19417    19414       -3     
- Misses        533      535       +2     
- Partials      185      186       +1     
Flag Coverage Δ
badger_v1 8.32% <ø> (ø)
badger_v2 1.68% <ø> (ø)
cassandra-4.x-v1 14.39% <ø> (ø)
cassandra-4.x-v2 1.62% <ø> (ø)
cassandra-5.x-v1 14.39% <ø> (ø)
cassandra-5.x-v2 1.62% <ø> (ø)
elasticsearch-6.x-v1 18.50% <ø> (-0.01%) ⬇️
elasticsearch-7.x-v1 18.59% <ø> (+<0.01%) ⬆️
elasticsearch-8.x-v1 18.76% <ø> (ø)
elasticsearch-8.x-v2 1.67% <ø> (ø)
grpc_v1 9.53% <ø> (ø)
grpc_v2 7.01% <ø> (ø)
kafka-v1 8.88% <ø> (ø)
kafka-v2 1.68% <ø> (ø)
memory_v2 1.68% <ø> (ø)
opensearch-1.x-v1 18.63% <ø> (-0.01%) ⬇️
opensearch-2.x-v1 18.63% <ø> (-0.01%) ⬇️
opensearch-2.x-v2 1.68% <ø> (+0.01%) ⬆️
tailsampling-processor 0.47% <ø> (ø)
unittests 95.33% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit 640615e into jaegertracing:main Oct 27, 2024
49 of 50 checks passed
yurishkuro added a commit to yurishkuro/jaeger that referenced this pull request Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:test Change that's adding missing tests or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants