Move all query service HTTP handlers into one function #6128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
yurishkuro
changed the title
4 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6128 +/- ##
==========================================
+ Coverage 96.41% 96.43% +0.01%
==========================================
Files 353 353
Lines 20137 20135 -2
==========================================
+ Hits 19416 19417 +1
+ Misses 535 533 -2
+ Partials 186 185 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yuri Shkuro <[email protected]>
|
@mahadzaryab1 please review |
mahadzaryab1
approved these changes
Oct 27, 2024
| } | ||
|
|
||
| if queryOpts.HTTP.TLSSetting != nil { | ||
| tlsCfg, err := queryOpts.HTTP.TLSSetting.LoadTLSConfig(ctx) // This checks if the certificates are correctly provided | ||
| if err != nil { | ||
| return nil, err | ||
| return nil, errors.Join(err, staticHandlerCloser.Close()) |
There was a problem hiding this comment.
ah that's why I was seeing the goleak errors - need to close the handler before exiting
| @@ -203,14 +203,13 @@ type httpServer struct { | |||
|
|
|||
| var _ io.Closer = (*httpServer)(nil) | |||
|
|
|||
| func createHTTPServer( | |||
| ctx context.Context, | |||
| func initRouter( | |||
There was a problem hiding this comment.
will it be okay to have redundant handlers with the otel implementation? specifically asking about the response headers handler and the compression handler.
Signed-off-by: Yuri Shkuro <[email protected]>
yurishkuro
added a commit
to yurishkuro/jaeger
that referenced
this pull request
Nov 2, 2024
…rtracing#6128)" This reverts commit bf06acf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
initRouterHow was this change tested?
go test ./cmd/query/app/...