Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jaeger-v2] Implement empty service name sanitizer for OTLP #6077

Merged
merged 16 commits into from
Oct 12, 2024
Merged

[jaeger-v2] Implement empty service name sanitizer for OTLP #6077

merged 16 commits into from
Oct 12, 2024
+234 −1

Conversation

mahadzaryab1
Copy link
Collaborator

Which problem is this PR solving?

Description of the changes

  • Created a new Sanitizer type for sanitizing traces in OTLP format
  • Implemented the empty service name sanitizer; I'll open a separate PR for the UTF-8 sanitizer

How was this change tested?

  • Unit tests

Checklist

@codecov Codecov
Copy link

codecov bot commented Oct 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.92%. Comparing base (563f3b0) to head (f3deafa).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6077      +/-   ##
==========================================
- Coverage   96.93%   96.92%   -0.01%     
==========================================
  Files         349      351       +2     
  Lines       16646    16675      +29     
==========================================
+ Hits        16135    16162      +27     
- Misses        328      329       +1     
- Partials      183      184       +1
Flag Coverage Δ
badger_v1 7.98% <ø> (ø)
badger_v2 1.84% <ø> (ø)
cassandra-4.x-v1 15.75% <ø> (ø)
cassandra-4.x-v2 1.77% <ø> (ø)
cassandra-5.x-v1 15.75% <ø> (ø)
cassandra-5.x-v2 1.77% <ø> (ø)
elasticsearch-6.x-v1 18.92% <ø> (-0.03%) ⬇️
elasticsearch-7.x-v1 19.01% <ø> (+0.01%) ⬆️
elasticsearch-8.x-v1 19.19% <ø> (-0.02%) ⬇️
elasticsearch-8.x-v2 1.84% <ø> (ø)
grpc_v1 9.36% <ø> (ø)
grpc_v2 7.12% <ø> (ø)
kafka-v1 9.68% <ø> (ø)
kafka-v2 1.84% <ø> (ø)
memory_v2 1.83% <ø> (ø)
opensearch-1.x-v1 19.05% <ø> (ø)
opensearch-2.x-v1 19.05% <ø> (ø)
opensearch-2.x-v2 1.84% <ø> (ø)
tailsampling-processor 0.49% <ø> (ø)
unittests 95.73% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro
Copy link
Member

do not capitalize all words in PR titles, only the first one (i.e. normal sentence case).

@mahadzaryab1 mahadzaryab1 changed the title [jaeger-v2] Implement Empty Service Name Sanitizer To Work With OTLP [jaeger-v2] Implement empty service name sanitizer to work with otlp Oct 12, 2024
@mahadzaryab1 mahadzaryab1 marked this pull request as ready for review October 12, 2024 02:47
@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner October 12, 2024 02:47
@dosubot dosubot bot added the v2 label Oct 12, 2024
@yurishkuro yurishkuro changed the title [jaeger-v2] Implement empty service name sanitizer to work with otlp [jaeger-v2] Implement empty service name sanitizer for OTLP Oct 12, 2024
@yurishkuro yurishkuro added the changelog:exprimental Change to an experimental part of the code label Oct 12, 2024
@yurishkuro yurishkuro merged commit 4beead7 into jaegertracing:main Oct 12, 2024
49 of 50 checks passed
@mahadzaryab1 mahadzaryab1 mentioned this pull request Oct 12, 2024
Merged
4 tasks
Saumya40-codes pushed a commit to Saumya40-codes/jaeger that referenced this pull request Oct 14, 2024
@mahadzaryab1
[jaeger-v2] Implement empty service name sanitizer for OTLP (jaegertr…
b0829d0 
…acing#6077)

## Which problem is this PR solving?
- Towards jaegertracing#5545

## Description of the changes
- Created a new `Sanitizer` type for sanitizing traces in OTLP format 
- Implemented the empty service name sanitizer; I'll open a separate PR
for the UTF-8 sanitizer

## How was this change tested?
- Unit tests

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---------

Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Saumya Shah <[email protected]>
Saumya40-codes pushed a commit to Saumya40-codes/jaeger that referenced this pull request Oct 14, 2024
@mahadzaryab1 @Saumya40-codes
[jaeger-v2] Implement empty service name sanitizer for OTLP (jaegertr…
c129591 
…acing#6077)

## Which problem is this PR solving?
- Towards jaegertracing#5545

## Description of the changes
- Created a new `Sanitizer` type for sanitizing traces in OTLP format
- Implemented the empty service name sanitizer; I'll open a separate PR
for the UTF-8 sanitizer

## How was this change tested?
- Unit tests

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---------

Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Saumya Shah <[email protected]>
yurishkuro pushed a commit that referenced this pull request Oct 14, 2024
@mahadzaryab1
[jaeger-v2] Implement UTF-8 sanitizer for OTLP (#6078)
c7e9f3d 
## Which problem is this PR solving?
- Resolves #5545 

## Description of the changes
- Continuation of #6077 to
implement the UTF-8 sanitizer to operate on OTLP data.

## How was this change tested?
- Unit tests 

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---------

Signed-off-by: Mahad Zaryab <[email protected]>
chahatsagarmain pushed a commit to chahatsagarmain/jaeger that referenced this pull request Oct 23, 2024
@mahadzaryab1 @chahatsagarmain
[jaeger-v2] Implement empty service name sanitizer for OTLP (jaegertr…
ed08c8d 
…acing#6077)

## Which problem is this PR solving?
- Towards jaegertracing#5545

## Description of the changes
- Created a new `Sanitizer` type for sanitizing traces in OTLP format 
- Implemented the empty service name sanitizer; I'll open a separate PR
for the UTF-8 sanitizer

## How was this change tested?
- Unit tests

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---------

Signed-off-by: Mahad Zaryab <[email protected]>
chahatsagarmain pushed a commit to chahatsagarmain/jaeger that referenced this pull request Oct 23, 2024
@mahadzaryab1 @chahatsagarmain
[jaeger-v2] Implement UTF-8 sanitizer for OTLP (jaegertracing#6078)
32e5a7f 
## Which problem is this PR solving?
- Resolves jaegertracing#5545 

## Description of the changes
- Continuation of jaegertracing#6077 to
implement the UTF-8 sanitizer to operate on OTLP data.

## How was this change tested?
- Unit tests 

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---------

Signed-off-by: Mahad Zaryab <[email protected]>
@mahadzaryab1 mahadzaryab1 deleted the v2-sanitizer branch October 31, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@jkowall jkowall Awaiting requested review from jkowall jkowall is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:exprimental Change to an experimental part of the code v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mahadzaryab1 @yurishkuro