testifylint: enable float-compare #5989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5989 +/- ##
==========================================
- Coverage 96.82% 96.81% -0.02%
==========================================
Files 345 345
Lines 16523 16523
==========================================
- Hits 15998 15996 -2
- Misses 339 340 +1
- Partials 186 187 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mmorel-35
force-pushed
the
testifylint/float-compare
branch
3 times, most recently
from
d5c2cfe
to
57d95f3
Compare
yurishkuro
reviewed
Sep 15, 2024
| @@ -258,10 +258,10 @@ func TestMissingServiceSamplingStrategyTypes(t *testing.T) { | |||
|
|
|||
| require.NotNil(t, s.OperationSampling) | |||
| os := s.OperationSampling | |||
| assert.EqualValues(t, defaultSamplingProbability, os.DefaultSamplingProbability) | |||
| assert.InEpsilon(t, defaultSamplingProbability, os.DefaultSamplingProbability, 0.0001) | |||
There was a problem hiding this comment.
What's the difference vs inDelta?
There was a problem hiding this comment.
There interfaces are quite similar I’m not sure but in my experience they both work the same way except that InEpsilon doesn’t work for a 0 expected value.
I would say that InEpsilon is for very small numbers but I don’t see anything prevising what a small number is.
I’ll keep InDelta instead
yurishkuro
added
the
changelog:test
mmorel-35
force-pushed
the
testifylint/float-compare
branch
4 times, most recently
from
4006fba
to
cd04c53
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
force-pushed
the
testifylint/float-compare
branch
from
cd04c53
to
47f5ab3
Compare
yurishkuro
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test