-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jaeger-v2] Align Cassandra Storage Config With OTEL #5949
[jaeger-v2] Align Cassandra Storage Config With OTEL #5949
Conversation
Signed-off-by: Mahad Zaryab <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5949 +/- ##
==========================================
+ Coverage 96.80% 96.90% +0.10%
==========================================
Files 349 349
Lines 16581 16582 +1
==========================================
+ Hits 16051 16069 +18
+ Misses 342 329 -13
+ Partials 188 184 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Is |
@yurishkuro This is ready for another look. The patch code coverage is failing because of a couple of lines which were modified that I'm assuming weren't tested before. Should I add some tests for |
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
migration doc not readable |
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Head branch was pushed to by a user without write access
@yurishkuro thank you so much for writing the tests! the linter was failing so I just fixed that. Auto merge was disabled so will need to be enabled or merged in again. |
sorry about that! just opened the access up |
I think we have a one-off failure for the ES test. I think a rerun of the CI should fix it since we didn't touch anything ES related in this PR. |
Which problem is this PR solving?
Description of the changes
Validate
methodconfigtls.ClientConfig
typeHow was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test