Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused "namespace" field from Badger config #5929

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Sep 3, 2024

Which problem is this PR solving?

Description of the changes

  • Remove the field, clean up the tests

How was this change tested?

  • CI

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.82%. Comparing base (ad6af7a) to head (2a6e6fa).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5929      +/-   ##
==========================================
+ Coverage   96.81%   96.82%   +0.01%     
==========================================
  Files         344      344              
  Lines       16531    16530       -1     
==========================================
+ Hits        16004    16005       +1     
+ Misses        340      339       -1     
+ Partials      187      186       -1     
Flag Coverage Δ
badger_v1 8.04% <11.11%> (-0.02%) ⬇️
badger_v2 1.82% <0.00%> (+<0.01%) ⬆️
cassandra-3.x-v1 16.61% <0.00%> (+<0.01%) ⬆️
cassandra-3.x-v2 1.75% <0.00%> (+<0.01%) ⬆️
cassandra-4.x-v1 16.61% <0.00%> (+<0.01%) ⬆️
cassandra-4.x-v2 1.75% <0.00%> (+<0.01%) ⬆️
elasticsearch-6.x-v1 18.79% <0.00%> (+<0.01%) ⬆️
elasticsearch-7.x-v1 18.85% <0.00%> (+0.01%) ⬆️
elasticsearch-8.x-v1 19.04% <0.00%> (+0.01%) ⬆️
elasticsearch-8.x-v2 1.81% <0.00%> (-0.02%) ⬇️
grpc_v1 9.49% <0.00%> (+0.01%) ⬆️
grpc_v2 7.15% <0.00%> (+<0.01%) ⬆️
kafka-v1 9.74% <0.00%> (+<0.01%) ⬆️
kafka-v2 1.82% <0.00%> (+<0.01%) ⬆️
memory_v2 1.82% <0.00%> (+<0.01%) ⬆️
opensearch-1.x-v1 18.89% <0.00%> (+0.01%) ⬆️
opensearch-2.x-v1 18.89% <0.00%> (+<0.01%) ⬆️
opensearch-2.x-v2 1.81% <0.00%> (+<0.01%) ⬆️
tailsampling-processor 0.46% <0.00%> (+<0.01%) ⬆️
unittests 95.30% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro marked this pull request as ready for review September 3, 2024 00:49
@yurishkuro yurishkuro requested a review from a team as a code owner September 3, 2024 00:49
@dosubot dosubot bot added the storage/badger Issues related to badger storage label Sep 3, 2024
@yurishkuro yurishkuro merged commit 7a8fe39 into jaegertracing:main Sep 4, 2024
50 checks passed
@yurishkuro yurishkuro deleted the clean-badger-config branch September 4, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant