Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract code to run test binary and log outputs #5902

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Aug 28, 2024

Extract code for running a binary in tests to be able to reuse it in other places.

@renovate-bot renovate-bot requested a review from a team as a code owner August 28, 2024 19:31
@forking-renovate forking-renovate bot added the changelog:dependencies Update to dependencies label Aug 28, 2024
@dosubot dosubot bot added the go label Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.81%. Comparing base (9a2921a) to head (5016425).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5902      +/-   ##
==========================================
- Coverage   96.82%   96.81%   -0.02%     
==========================================
  Files         342      342              
  Lines       16524    16524              
==========================================
- Hits        15999    15997       -2     
- Misses        339      340       +1     
- Partials      186      187       +1     
Flag Coverage Δ
badger_v1 8.05% <ø> (ø)
badger_v2 1.82% <ø> (ø)
cassandra-3.x-v1 16.62% <ø> (ø)
cassandra-3.x-v2 1.75% <ø> (ø)
cassandra-4.x-v1 16.62% <ø> (ø)
cassandra-4.x-v2 1.75% <ø> (ø)
elasticsearch-6.x-v1 18.79% <ø> (ø)
elasticsearch-7.x-v1 18.85% <ø> (ø)
elasticsearch-8.x-v1 19.03% <ø> (-0.02%) ⬇️
elasticsearch-8.x-v2 1.82% <ø> (+0.01%) ⬆️
grpc_v1 9.49% <ø> (ø)
grpc_v2 7.16% <ø> (ø)
kafka-v1 9.74% <ø> (ø)
kafka-v2 1.82% <ø> (ø)
memory_v2 1.81% <ø> (-0.02%) ⬇️
opensearch-1.x-v1 18.89% <ø> (ø)
opensearch-2.x-v1 18.89% <ø> (-0.02%) ⬇️
opensearch-2.x-v2 1.82% <ø> (+0.01%) ⬆️
unittests 95.29% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate-bot renovate-bot force-pushed the renovate/github.com-prometheus-common-0.x branch from 01fb267 to 3cddade Compare August 29, 2024 04:34
@yurishkuro yurishkuro changed the title Update module github.com/prometheus/common to v0.57.0 Extract code to run test binary and log outputs Aug 31, 2024
@yurishkuro yurishkuro enabled auto-merge (squash) August 31, 2024 05:33
@yurishkuro yurishkuro added changelog:test Change that's adding missing tests or correcting existing tests and removed changelog:dependencies Update to dependencies go labels Aug 31, 2024
@yurishkuro yurishkuro merged commit 9a30dfc into jaegertracing:main Aug 31, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:test Change that's adding missing tests or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants