-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run v2 e2e integration tests for Kafka #5782
Conversation
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5782 +/- ##
=======================================
Coverage 96.65% 96.65%
=======================================
Files 342 342
Lines 16519 16519
=======================================
Hits 15966 15966
Misses 363 363
Partials 190 190
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: joeyyy09 <[email protected]>
the v2 check failed, looking into it. |
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: joeyyy09 <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
I pushed the following fix (30ceb02):
With these changes the test is now succeeding |
Signed-off-by: Yuri Shkuro <[email protected]>
Makes sense, thanks! |
Which problem is this PR solving?
Description of the changes
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test