Add reliable check for Kafka broker being ready #5154
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #5148
Description of the changes
nc
to check the availability of theKafka port
, which was not reliable, especially when the Kafka container was started asynchronously. The updated script now ensures a more reliable check for Kafka readiness by attempting to list topics usingkafka-topics.sh
within a loop. This modification ensures that the script waits until Kafka is fully initialized before proceeding with integration tests.How was this change tested?
bash scripts/kafka-integration-test.sh -k
from the project root.Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test