Clean-up APIv3 tests #5046
Merged
Clean-up APIv3 tests #5046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <[email protected]>
yurishkuro
added
the
changelog:test
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5046 +/- ##
==========================================
- Coverage 95.62% 95.58% -0.04%
==========================================
Files 319 319
Lines 18794 18794
==========================================
- Hits 17971 17965 -6
- Misses 661 665 +4
- Partials 162 164 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
albertteoh
approved these changes
Dec 27, 2023
|
It does not remove the dependency yet. I first want to have good tests that exercise v3 api via http, and then replace the gateway implementation. |
This was referenced Dec 27, 2023
yurishkuro
added a commit
that referenced
this pull request
Dec 28, 2023
## Which problem is this PR solving? - Part of #5052 - Continuation of #5046 ## Description of the changes - Add tests for all HTTP APIs, not just GetTrace - Use snapshots to make validation of HTTP/JSON response from the server easier - Replace grpc-gateway/runtime JSONPb marshaler (in tests) with gogo/jsonpb marshaler ## Gaps - The error conditions are not being tested currently, such as not specifying the timestamps in the query ## How was this change tested? - Unit tests --------- Signed-off-by: Yuri Shkuro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?