Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare all interfaces each factory implements #4967

Merged
merged 1 commit into from
Nov 26, 2023

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • Explicitly declare all interfaces each factory implements
  • Move these declarations to the main file for visibility

How was this change tested?

  • CI

@yurishkuro yurishkuro added the changelog:test Change that's adding missing tests or correcting existing tests label Nov 26, 2023
@yurishkuro yurishkuro requested a review from a team as a code owner November 26, 2023 15:29
Copy link

codecov bot commented Nov 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (47f39a8) 95.60% compared to head (515a20e) 95.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4967      +/-   ##
==========================================
- Coverage   95.60%   95.58%   -0.03%     
==========================================
  Files         317      317              
  Lines       18689    18689              
==========================================
- Hits        17868    17863       -5     
- Misses        659      663       +4     
- Partials      162      163       +1     
Flag Coverage Δ
cassandra-3.x 25.64% <ø> (ø)
cassandra-4.x 25.64% <ø> (ø)
elasticsearch-5.x 19.91% <ø> (ø)
elasticsearch-6.x 19.90% <ø> (-0.02%) ⬇️
elasticsearch-7.x 20.03% <ø> (-0.02%) ⬇️
elasticsearch-8.x 20.14% <ø> (ø)
grpc-badger 19.55% <ø> (ø)
kafka 14.07% <ø> (ø)
opensearch-1.x 20.03% <ø> (-0.02%) ⬇️
opensearch-2.x 20.05% <ø> (ø)
unittests 93.33% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jkowall jkowall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@yurishkuro yurishkuro merged commit 4096fe9 into jaegertracing:main Nov 26, 2023
37 checks passed
@yurishkuro yurishkuro deleted the factory-interfaces branch November 26, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:test Change that's adding missing tests or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants