-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace python script with tracegen #4753
Replace python script with tracegen #4753
Conversation
Signed-off-by: albertteoh <[email protected]>
Signed-off-by: albertteoh <[email protected]>
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
docker run --env OTEL_EXPORTER_OTLP_TRACES_ENDPOINT="http://otel_collector:4317" \ | ||
--network monitor_backend \ | ||
--rm \ | ||
jaegertracing/jaeger-tracegen:1.49 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if there's a preference to use the latest
tag.
you can also remove the respective section in .github/dependabot.yml |
Signed-off-by: albertteoh <[email protected]>
Signed-off-by: albertteoh <[email protected]>
@@ -22,8 +22,6 @@ services: | |||
volumes: | |||
- ${OTEL_CONFIG_SRC:-./otel-collector-config-connector.yml}:/etc/otelcol/otel-collector-config.yml | |||
command: --config /etc/otelcol/otel-collector-config.yml | |||
ports: | |||
- "4317:4317" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that I've also removed this as we're executing tracegen in the same monitor_backend
network. Tested this locally to make sure:
# Fail to access the port from host machine.
$ telnet localhost 4317
Trying 127.0.0.1...
telnet: Unable to connect to remote host: Connection refused
# Successfully write to port from docker command.
$ docker run --env OTEL_EXPORTER_OTLP_TRACES_ENDPOINT="http://otel_collector:4317" \
--network monitor_backend \
--rm \
jaegertracing/jaeger-tracegen:1.49 \
-trace-exporter otlp-grpc \
-traces 1
...
2023-09-12T20:40:01.903Z LEVEL(-8) global/internal_logging.go:62 exporting spans {"count": 2, "total_dropped": 0}
Nice, thanks. Removed in: b850f02 |
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
- [] I have added unit tests for the new functionalityjaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test