-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Stop using constants from jaeger-client-go #4681
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4681 +/- ##
==========================================
- Coverage 97.04% 96.96% -0.08%
==========================================
Files 301 301
Lines 17880 17881 +1
==========================================
- Hits 17352 17339 -13
- Misses 423 437 +14
Partials 105 105
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
aa1388a
to
1d6c293
Compare
eae6456
to
10d18e6
Compare
But Yuri, I got to find chaining effect due to that. jaeger/cmd/collector/app/metrics.go Line 234 in 10d18e6
I am stuck here since its util is having unchanged method. LMK! jaeger/cmd/collector/app/metrics.go Line 281 in 10d18e6
|
Signed-off-by: afzal442 <[email protected]>
Signed-off-by: afzal442 <[email protected]>
Signed-off-by: afzal442 <[email protected]>
Signed-off-by: afzal442 <[email protected]>
Signed-off-by: afzal442 <[email protected]>
0edbc7d
to
5bf41b6
Compare
Signed-off-by: afzal442 <[email protected]>
Signed-off-by: afzal442 <[email protected]>
5bf41b6
to
78f55cd
Compare
Signed-off-by: afzal442 <[email protected]>
511e3b0
to
6cb50f3
Compare
Signed-off-by: afzal442 <[email protected]>
## Which problem is this PR solving? - Minor clean-up after #4681 ## Description of the changes - Add tests for `model.SamplerType.String()` - Refactor `cmd/collector/app/metrics.go` to use `model.SamplerType` more directly ## How was this change tested? - Unit tests Signed-off-by: Yuri Shkuro <[email protected]>
Which problem is this PR solving?
jaeger-client
pkg constant and replaces it with const variable