Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Stop using constants from jaeger-client-go #4681

Merged
merged 9 commits into from
Sep 4, 2023

Conversation

afzal442
Copy link
Contributor

Which problem is this PR solving?

@afzal442 afzal442 requested a review from a team as a code owner August 17, 2023 10:45
@afzal442 afzal442 requested a review from jkowall August 17, 2023 10:45
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage: 62.16% and project coverage change: -0.08% ⚠️

Comparison is base (f1658ed) 97.04% compared to head (7167add) 96.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4681      +/-   ##
==========================================
- Coverage   97.04%   96.96%   -0.08%     
==========================================
  Files         301      301              
  Lines       17880    17881       +1     
==========================================
- Hits        17352    17339      -13     
- Misses        423      437      +14     
  Partials      105      105              
Flag Coverage Δ
unittests 96.96% <62.16%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
model/span.go 87.61% <46.15%> (-12.39%) ⬇️
cmd/collector/app/metrics.go 100.00% <100.00%> (ø)
cmd/collector/app/root_span_handler.go 100.00% <100.00%> (ø)
...ugin/sampling/strategystore/adaptive/aggregator.go 62.71% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afzal442 afzal442 force-pushed the rmv-jaeger-const branch 2 times, most recently from aa1388a to 1d6c293 Compare August 19, 2023 18:02
model/span.go Outdated Show resolved Hide resolved
model/span.go Outdated Show resolved Hide resolved
model/span.go Outdated Show resolved Hide resolved
model/span.go Outdated Show resolved Hide resolved
@afzal442
Copy link
Contributor Author

But Yuri, I got to find chaining effect due to that.

if span.ParentSpanID() == 0 {

I am stuck here since its util is having unchanged method. LMK!

tags := map[string]string{"svc": serviceName, "debug": debugStr, samplerTypeKey: samplerType}

model/span.go Outdated Show resolved Hide resolved
model/span.go Outdated Show resolved Hide resolved
model/span.go Show resolved Hide resolved
model/span.go Outdated Show resolved Hide resolved
model/span.go Outdated Show resolved Hide resolved
model/span_test.go Outdated Show resolved Hide resolved
model/span.go Show resolved Hide resolved
model/span.go Outdated Show resolved Hide resolved
model/span.go Outdated Show resolved Hide resolved
model/span.go Outdated Show resolved Hide resolved
cmd/collector/app/root_span_handler.go Outdated Show resolved Hide resolved
model/span.go Show resolved Hide resolved
@afzal442 afzal442 changed the title Removes jaeger-client constant [WIP] Removes jaeger-client constant Aug 22, 2023
@afzal442 afzal442 requested a review from yurishkuro August 22, 2023 18:45
model/span.go Outdated Show resolved Hide resolved
model/span.go Outdated Show resolved Hide resolved
Signed-off-by: afzal442 <[email protected]>
model/span.go Show resolved Hide resolved
model/span.go Outdated Show resolved Hide resolved
model/span.go Outdated Show resolved Hide resolved
@yurishkuro yurishkuro changed the title [WIP] Removes jaeger-client constant [chore] Stop using constants from jaeger-client-go Sep 4, 2023
@yurishkuro yurishkuro merged commit 390c4a8 into jaegertracing:main Sep 4, 2023
1 check passed
yurishkuro added a commit that referenced this pull request Sep 4, 2023
## Which problem is this PR solving?
- Minor clean-up after #4681

## Description of the changes
- Add tests for `model.SamplerType.String()`
- Refactor `cmd/collector/app/metrics.go` to use `model.SamplerType`
more directly

## How was this change tested?
- Unit tests

Signed-off-by: Yuri Shkuro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants