Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotrod/observer_test] Switch to OpenTelemetry #4635

Merged
merged 9 commits into from
Aug 12, 2023

Conversation

afzal442
Copy link
Contributor

@afzal442 afzal442 commented Aug 7, 2023

Which problem is this PR solving?

Short description of the changes

  • Replace OT const with otel trace spans const i.e. ext.SpanKind.. with trace.SpanKind.. and its trace API

@afzal442 afzal442 requested a review from a team as a code owner August 7, 2023 18:50
@afzal442 afzal442 requested a review from yurishkuro August 7, 2023 18:50
@afzal442 afzal442 force-pushed the replace-ot-wid-otel-hotrod branch from fb73f2a to 7adf845 Compare August 8, 2023 19:23
Signed-off-by: Afzal <[email protected]>
yurishkuro
yurishkuro previously approved these changes Aug 10, 2023
Signed-off-by: Afzal <[email protected]>
@sbin64
Copy link
Contributor

sbin64 commented Aug 10, 2023 via email

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03% ⚠️

Comparison is base (5b9e7e1) 97.06% compared to head (cefff81) 97.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4635      +/-   ##
==========================================
- Coverage   97.06%   97.04%   -0.03%     
==========================================
  Files         301      301              
  Lines       17878    17878              
==========================================
- Hits        17354    17350       -4     
- Misses        420      423       +3     
- Partials      104      105       +1     
Flag Coverage Δ
unittests 97.04% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
model/span.go 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro changed the title [hotROD] Replace ot traces and const with otel [hotrod/observer_test] Switch to OpenTelemetry Aug 12, 2023
@yurishkuro yurishkuro merged commit 941c115 into jaegertracing:main Aug 12, 2023
@afzal442 afzal442 deleted the replace-ot-wid-otel-hotrod branch August 13, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants