[test] Replace OT const with OTEL #4624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
reviewed
Aug 4, 2023
cmd/query/app/handler_options.go
Outdated
| func (handlerOptions) Tracer(tracer *jtracer.JTracer) HandlerOption { | ||
| return func(apiHandler *APIHandler) { | ||
| apiHandler.tracer = tracer | ||
| apiHandler.tracer.OTEL = tracer.OTEL |
There was a problem hiding this comment.
I did this to workaround if it was desirable.
yurishkuro
reviewed
Aug 4, 2023
cmd/query/app/handler_options.go
Outdated
| @@ -61,10 +61,10 @@ func (handlerOptions) QueryLookbackDuration(queryLookbackDuration time.Duration) | |||
| } | |||
| } | |||
|
|
|||
| // Tracer creates a HandlerOption that initializes OpenTracing tracer | |||
| // Tracer creates a HandlerOption that initializes Opentelemetry tracer | |||
There was a problem hiding this comment.
Suggested change
| // Tracer creates a HandlerOption that initializes Opentelemetry tracer | |
| // Tracer creates a HandlerOption that passes the tracer to the handler |
Signed-off-by: Afzal Ansari <[email protected]>
sbin64
force-pushed
the
replace-ot-const-with-otel
branch
from
a7bffdb to
30b94b0
Compare
Signed-off-by: Afzal <[email protected]>
sbin64
force-pushed
the
replace-ot-const-with-otel
branch
from
30b94b0 to
70012d2
Compare
yurishkuro
approved these changes
Aug 4, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4624 +/- ##
=======================================
Coverage 97.06% 97.07%
=======================================
Files 301 301
Lines 17877 17878 +1
=======================================
+ Hits 17353 17355 +2
+ Misses 420 419 -1
Partials 104 104
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
yurishkuro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
otel tracespans type to span modelShort description of the changes
otel tracespans const i.e.ext.SpanKind..withtrace.SpanKind..