Replace Jaeger SDK with OTEL SDK + OT Bridge

[afzal442]

Which problem is this PR solving?

• Part of Upgrade internal use of tracing to OpenTelemetry #3381
• This PR adds OTEL Provider to jtracer pkg

Short description of the changes

• Upgrades jaeger tracing to support otel tracer

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (587fb74) 97.03% compared to head (f905480) 97.07%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4574      +/-   ##
==========================================
+ Coverage   97.03%   97.07%   +0.03%     
==========================================
  Files         301      301              
  Lines       17839    17857      +18     
==========================================
+ Hits        17310    17334      +24     
+ Misses        424      419       -5     
+ Partials      105      104       -1     

Flag	Coverage Δ
unittests	97.07% <100.00%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
cmd/query/app/grpc_handler.go	98.78% <100.00%> (ø)
cmd/query/app/handler_options.go	100.00% <100.00%> (ø)
cmd/query/app/http_handler.go	100.00% <100.00%> (ø)
cmd/query/app/server.go	94.57% <100.00%> (ø)

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[albertteoh]

Hmmm... I wonder why we don't annotate and return the error here instead of logging it.

[yurishkuro]

I think mostly because if we return an error, it is intercepted at the top level of main like this:

	if err := command.Execute(); err != nil {
		log.Fatal(err)
	}

Here the zapp logger is not available so the stdlib log is used, which is formatted differently. E.g.:

$ go run ./cmd/all-in-one --admin.http.tls.enabled=true --admin.http.tls.key=invalid
. . .
2023/07/20 11:43:08 cannot initialize admin server: failed to watch key pair invalid and : open invalid: no such file or directory
exit status 1

With zapp logs you get line number and other nice things. E.g.

$ go run ./cmd/all-in-one --reporter.grpc.tls.enabled=true --reporter.grpc.tls.key=nopath
. . .
{"level":"fatal","ts":1689868046.063343,"caller":"all-in-one/main.go:192","msg":"Could not create collector proxy","error":"failed to load TLS config: failed to watch key pair nopath and : open nopath: no such file or directory","stacktrace":"main.main.func1\n\t/Users/ysh/dev/jaegertracing/jaeger/cmd/all-in-one/main.go:192\ngithub.com/spf13/cobra.(*Command).execute\n\t/Users/ysh/golang/pkg/mod/github.com/spf13/[email protected]/command.go:940\ngithub.com/spf13/cobra.(*Command).ExecuteC\n\t/Users/ysh/golang/pkg/mod/github.com/spf13/[email protected]/command.go:1068\ngithub.com/spf13/cobra.(*Command).Execute\n\t/Users/ysh/golang/pkg/mod/github.com/spf13/[email protected]/command.go:992\nmain.main\n\t/Users/ysh/dev/jaegertracing/jaeger/cmd/all-in-one/main.go:243\nruntime.main\n\t/Users/ysh/homebrew/Cellar/go/1.20.5/libexec/src/runtime/proc.go:250"}
exit status 1

[afzal442]

That's cool thing I noticed here. 🏷️

[albertteoh]

Is it a good time to remove the [WIP] from the PR title?