Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some comments #4410

Merged
merged 2 commits into from
May 27, 2023
Merged

fix some comments #4410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52297e0
fix some comments
cuishuang Apr 25, 2023
4a22cf6
Merge branch 'main' into main
yurishkuro May 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/agent/app/reporter/grpc/reporter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ func (r *Reporter) send(ctx context.Context, spans []*model.Span, process *model
return err
}

// addTags appends jaeger tags for the agent to every span it sends to the collector.
// addProcessTags appends jaeger tags for the agent to every span it sends to the collector.
func addProcessTags(spans []*model.Span, process *model.Process, agentTags []model.KeyValue) ([]*model.Span, *model.Process) {
if len(agentTags) == 0 {
return spans, process
Expand Down
2 changes: 1 addition & 1 deletion cmd/query/app/query_parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ func parseBool(r *http.Request, paramName string) (b bool, err error) {
return b, nil
}

// parseSpanKindParam parses the input span kinds to filter for in the metrics query.
// parseSpanKinds parses the input span kinds to filter for in the metrics query.
//
// Valid input span kinds include:
// - "unspecified": when no span kind specified in span.
Expand Down
2 changes: 1 addition & 1 deletion plugin/sampling/strategystore/static/strategy_store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ func (h *strategyStore) parseStrategies(strategies *strategies) {
h.storedStrategies.Store(newStore)
}

// mergePerOperationStrategies merges two operation strategies a and b, where a takes precedence over b.
// mergePerOperationSamplingStrategies merges two operation strategies a and b, where a takes precedence over b.
func mergePerOperationSamplingStrategies(
a, b []*api_v2.OperationSamplingStrategy,
) []*api_v2.OperationSamplingStrategy {
Expand Down