Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions to send traces in SPM Dev Env #3996

Merged
merged 8 commits into from
Oct 31, 2022

Conversation

albertteoh
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Remove unused jaeger all-in-one exposed ports.
  • Add instructions explaining how to traces from a custom application with examples and screenshots.

@albertteoh albertteoh requested a review from a team as a code owner October 24, 2022 10:56
@albertteoh albertteoh requested a review from vprithvi October 24, 2022 10:56
@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Base: 97.17% // Head: 97.15% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (5c65564) compared to base (9722d23).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3996      +/-   ##
==========================================
- Coverage   97.17%   97.15%   -0.02%     
==========================================
  Files         295      295              
  Lines       17390    17390              
==========================================
- Hits        16898    16895       -3     
- Misses        396      398       +2     
- Partials       96       97       +1     
Flag Coverage Δ
unittests 97.15% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/query/app/static_handler.go 96.38% <0.00%> (-1.81%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@albertteoh albertteoh changed the title Expose traces http port Add instructions to send traces in SPM Dev Env Oct 24, 2022
Fetch the minimum step size supported by the underlying metrics store.
```bash
curl "http://localhost:16686/api/metrics/minstep" | jq .
```

# HTTP API
# HTTP API Specification
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered defining this as a swagger spec, but given its only "user" is Jaeger UI, I don't think it's worth the effort.


jaeger_exporter = JaegerExporter(
collector_endpoint="http://localhost:14278/api/traces",
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest using OTLP exporter instead and exposing OTLP port in the OTEL Collector.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my learning, why the preference for OTLP over Jaeger formatted spans?

Done in ab3dd6b.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because jaeger SDKs are deprecated, the recommended path is native OTEL

- "16686:16686"
- "16685:16685"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't one of these ports still needed to receive data from OTEL collector?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, all ports are accessible between containers. Only the ports that need to be exposed to the "outside world" should be listed under ports.

@yurishkuro yurishkuro merged commit 1e4002e into jaegertracing:main Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants