-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions to send traces in SPM Dev Env #3996
Add instructions to send traces in SPM Dev Env #3996
Conversation
Signed-off-by: albertteoh <[email protected]>
Signed-off-by: albertteoh <[email protected]>
Signed-off-by: albertteoh <[email protected]>
Codecov ReportBase: 97.17% // Head: 97.15% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #3996 +/- ##
==========================================
- Coverage 97.17% 97.15% -0.02%
==========================================
Files 295 295
Lines 17390 17390
==========================================
- Hits 16898 16895 -3
- Misses 396 398 +2
- Partials 96 97 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Fetch the minimum step size supported by the underlying metrics store. | ||
```bash | ||
curl "http://localhost:16686/api/metrics/minstep" | jq . | ||
``` | ||
|
||
# HTTP API | ||
# HTTP API Specification |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I considered defining this as a swagger spec, but given its only "user" is Jaeger UI, I don't think it's worth the effort.
|
||
jaeger_exporter = JaegerExporter( | ||
collector_endpoint="http://localhost:14278/api/traces", | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest using OTLP exporter instead and exposing OTLP port in the OTEL Collector.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my learning, why the preference for OTLP over Jaeger formatted spans?
Done in ab3dd6b.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because jaeger SDKs are deprecated, the recommended path is native OTEL
- "16686:16686" | ||
- "16685:16685" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't one of these ports still needed to receive data from OTEL collector?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, all ports are accessible between containers. Only the ports that need to be exposed to the "outside world" should be listed under ports
.
Which problem is this PR solving?
Short description of the changes