Zipkin span start time and duration sanitizer #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavolloffay
requested review from
black-adder,
oibe,
vprithvi and
yurishkuro
as code owners
yurishkuro
reviewed
Aug 15, 2017
| if anno.Value == zc.CLIENT_SEND { | ||
| span.Timestamp = &anno.Timestamp | ||
| return span | ||
| } else if anno.Value == zc.SERVER_RECV && span.ParentID == nil { |
There was a problem hiding this comment.
else is redundant since previous if ends with return
| span.Timestamp = &anno.Timestamp | ||
| return span | ||
| } else if anno.Value == zc.SERVER_RECV && span.ParentID == nil { | ||
| span.Timestamp = &anno.Timestamp |
There was a problem hiding this comment.
comment explaining why not breaking out of loop in this case?
| } | ||
| if first != last { | ||
| duration := last - first | ||
| span.Duration = &duration |
There was a problem hiding this comment.
double allocation with L85 - better to declare local var duration and do span.Duration = &duration at the end of if
| last = anno.Timestamp | ||
| } | ||
| } | ||
| if first != last { |
There was a problem hiding this comment.
maybe first < last? Otherwise you can assign negative TS
pavolloffay
force-pushed
the
zipkin-start-time-duration-sanitizer
branch
from
44c6dd5 to
675c709
Compare
|
@yurishkuro thanks for the quick look. PR updated |
|
close/open to trigger travis build. |
yurishkuro
approved these changes
Aug 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to: https://github.com/openzipkin/zipkin/blob/master/zipkin/src/main/java/zipkin/internal/ApplyTimestampAndDuration.java
This is required for follow-up PR with zipkin JSON encoding.