Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add adaptive sampling tables to v4 #3300

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

joe-elliott
Copy link
Member

Short description of the changes

#2966 Added support for adaptive sampling which included 3 new cassandra tables. Meanwhile #3225 created a new cassandra schema template file v004.cql.tmpl. Because these two PRs were in flight at the same time the v004.cql.tmpl file did not include the tables necessary for adaptive sampling. Adding them here.

@joe-elliott joe-elliott requested a review from a team as a code owner October 1, 2021 19:37
@joe-elliott joe-elliott requested a review from jpkrohling October 1, 2021 19:37
@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #3300 (75309a3) into master (c1db700) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3300      +/-   ##
==========================================
- Coverage   95.86%   95.83%   -0.04%     
==========================================
  Files         259      259              
  Lines       15413    15413              
==========================================
- Hits        14776    14771       -5     
- Misses        548      552       +4     
- Partials       89       90       +1     
Impacted Files Coverage Δ
pkg/config/tlscfg/cert_watcher.go 92.63% <0.00%> (-2.11%) ⬇️
cmd/query/app/static_handler.go 95.80% <0.00%> (-1.80%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1db700...75309a3. Read the comment docs.

@yurishkuro yurishkuro merged commit 0bdcec8 into jaegertracing:master Oct 1, 2021
@joe-elliott joe-elliott added this to the v1.27.0 milestone Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants