Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log the source of sampling strategies #3166

Merged
merged 2 commits into from
Jul 28, 2021

Conversation

yurishkuro
Copy link
Member

Help with #2197

$ go run ./cmd/all-in-one --sampling.strategies-file cmd/all-in-one/sampling_strategies.json
...
{"level":"info","ts":1627395862.803787,"caller":"static/strategy_store.go:138","msg":"Loading sampling strategies","filename":"cmd/all-in-one/sampling_strategies.json"}
...

@yurishkuro yurishkuro requested a review from a team as a code owner July 27, 2021 14:27
@yurishkuro yurishkuro requested a review from vprithvi July 27, 2021 14:27
Signed-off-by: Yuri Shkuro <[email protected]>
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #3166 (31a2f9e) into master (779027c) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3166      +/-   ##
==========================================
- Coverage   95.92%   95.91%   -0.01%     
==========================================
  Files         239      239              
  Lines       14647    14649       +2     
==========================================
+ Hits        14050    14051       +1     
- Misses        520      521       +1     
  Partials       77       77              
Impacted Files Coverage Δ
...in/sampling/strategystore/static/strategy_store.go 97.26% <100.00%> (+0.02%) ⬆️
cmd/query/app/server.go 94.11% <0.00%> (-1.48%) ⬇️
plugin/storage/integration/integration.go 78.88% <0.00%> (-0.40%) ⬇️
cmd/query/app/static_handler.go 97.60% <0.00%> (+1.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 779027c...31a2f9e. Read the comment docs.

@albertteoh albertteoh merged commit 904a67c into jaegertracing:master Jul 28, 2021
@yurishkuro yurishkuro deleted the log-sampling-file branch July 28, 2021 04:04
@vprithvi vprithvi added this to the Release 1.25.0 milestone Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants