Add ppc64le support on multiarch docker images #3151
Conversation
Signed-off-by: Krishna Harsha Voora <[email protected]>
|
Jobs restarted, looks like there was a problem logging in to Docker Hub. |
docker/debug/Dockerfile
Outdated
| @@ -5,7 +5,7 @@ ARG TARGETARCH | |||
| ENV GOPATH /go | |||
| RUN apk add --update --no-cache ca-certificates make git | |||
| #Once go-delve adds support for s390x (see PR #2948), remove this entire conditional. | |||
| RUN if [[ "$TARGETARCH" != "s390x" ]] ; then \ | |||
| RUN if [[ "$TARGETARCH" != "s390x" ] || [ "$TARGETARCH" != "ppc64le" ]] ; then \ | |||
There was a problem hiding this comment.
Is there a similar PR for delve to address ppc64le? If so, we need to list it here, as we are doing with s390x
There was a problem hiding this comment.
Yes, currently the same is discussed via go-delve/delve#1564
So do you want this to go inside the PR, just like the way it is done for s390x?
There was a problem hiding this comment.
Ok, added the required details into the PR.
Codecov Report
@@ Coverage Diff @@
## master #3151 +/- ##
==========================================
+ Coverage 95.91% 95.97% +0.06%
==========================================
Files 239 239
Lines 14647 14647
==========================================
+ Hits 14048 14058 +10
+ Misses 521 514 -7
+ Partials 78 75 -3
Continue to review full report at Codecov.
|
Signed-off-by: Krishna Harsha Voora <[email protected]>
Head branch was pushed to by a user without write access
|
Ok, looks like there was a problem logging in to Docker Hub, hence the failure and not related to PR |
|
Could you please re-create the PR from a named branch in your fork, not from master? This is what's causing docker login failures. |
|
Closing this PR. |
Pull request was closed
Signed-off-by: Krishna Harsha Voora [email protected]
Which problem is this PR solving?
Re-adding the support for ppc64le arch, as it was missing in the following files.
Short description of the changes
docker/Makefile,scripts/build-all-in-one-image.sh,scripts/build-upload-docker-images.sh,scripts/hotrod-intergration-test.sh&docker/debug/Dockerfile