Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gbrown as emeritus maintainer #3122

Merged
merged 1 commit into from
Jul 2, 2021
Merged

gbrown as emeritus maintainer #3122

merged 1 commit into from
Jul 2, 2021

Conversation

jpkrohling
Copy link
Contributor

@objectiser has expressed his desire to resign as a maintainer of the Jaeger project, and this PR formalizes the vote/move. Once this PR is merged, I'll change the GitHub group accordingly.

Thank you very much for your contributions, @objectiser, including the over 200 PRs you created and 300 issues you opened.

Signed-off-by: Juraci Paixão Kröhling [email protected]

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
@jpkrohling jpkrohling requested a review from a team as a code owner July 2, 2021 09:51
@jpkrohling jpkrohling requested a review from objectiser July 2, 2021 09:51
Copy link
Contributor

@objectiser objectiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jpkrohling . It has been a pleasure working on the project and with you all!

@codecov
Copy link

codecov bot commented Jul 2, 2021

Codecov Report

Merging #3122 (2ac98ea) into master (44b2278) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3122      +/-   ##
==========================================
- Coverage   95.94%   95.92%   -0.02%     
==========================================
  Files         236      236              
  Lines       10238    10238              
==========================================
- Hits         9823     9821       -2     
- Misses        345      347       +2     
  Partials       70       70              
Impacted Files Coverage Δ
pkg/config/tlscfg/cert_watcher.go 92.20% <0.00%> (-2.60%) ⬇️
plugin/storage/badger/spanstore/reader.go 95.37% <0.00%> (-0.72%) ⬇️
cmd/query/app/server.go 97.22% <0.00%> (+1.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44b2278...2ac98ea. Read the comment docs.

@jpkrohling jpkrohling merged commit af2c29b into jaegertracing:master Jul 2, 2021
@jkowall
Copy link
Contributor

jkowall commented Jul 2, 2021

We will miss you @objectiser thanks for all your amazing work on the project.

@jpkrohling jpkrohling deleted the jpkrohling/gbrown-as-emeritus-maintainer branch July 28, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants