Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix http response header (#2924) #2925

Closed
wants to merge 1 commit into from
Closed

fix http response header (#2924) #2925

wants to merge 1 commit into from

Conversation

logeable
Copy link
Contributor

@logeable logeable commented Apr 6, 2021

Which problem is this PR solving?

Short description of the changes

@logeable logeable requested a review from a team as a code owner April 6, 2021 10:19
@logeable logeable requested a review from albertteoh April 6, 2021 10:19
@logeable logeable closed this Apr 6, 2021
@logeable logeable reopened this Apr 6, 2021
@codecov
Copy link

codecov bot commented Apr 6, 2021

Codecov Report

Merging #2925 (0d6afec) into master (33e8e96) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2925      +/-   ##
==========================================
+ Coverage   95.91%   95.97%   +0.06%     
==========================================
  Files         223      223              
  Lines        9708     9708              
==========================================
+ Hits         9311     9317       +6     
+ Misses        327      324       -3     
+ Partials       70       67       -3     
Impacted Files Coverage Δ
pkg/healthcheck/handler.go 100.00% <100.00%> (ø)
plugin/storage/integration/integration.go 77.34% <0.00%> (-0.56%) ⬇️
plugin/storage/badger/spanstore/reader.go 96.08% <0.00%> (+0.71%) ⬆️
cmd/query/app/server.go 97.08% <0.00%> (+1.45%) ⬆️
cmd/query/app/static_handler.go 96.77% <0.00%> (+1.61%) ⬆️
cmd/collector/app/server/zipkin.go 76.92% <0.00%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33e8e96...0d6afec. Read the comment docs.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

In the future, please add Resolve #1234 to the description to link & close the respective ticket.

@yurishkuro
Copy link
Member

@Ashmita152 this is an interesting example where many GH actions fail because the source branch of the fork is also master, and it's confusing the scripts into thinking they need to do Docker release as if it was on real master.

@yurishkuro
Copy link
Member

@logeable do you mind re-creating this PR from a named branch in your fork? In general, I do not recommend doing PRs from master even in your own fork, it's best to keep master in sync with upstream.

@logeable
Copy link
Contributor Author

logeable commented Apr 6, 2021

Thanks!

In the future, please add Resolve #1234 to the description to link & close the respective ticket.

Thanks for reminding.

@logeable
Copy link
Contributor Author

logeable commented Apr 6, 2021

@logeable do you mind re-creating this PR from a named branch in your fork? In general, I do not recommend doing PRs from master even in your own fork, it's best to keep master in sync with upstream.

Ok, I'll create a new pr.

@logeable logeable closed this Apr 6, 2021
@jpkrohling jpkrohling added this to the Release 1.23.0 milestone Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The response ContentType of HealthCheck.Handler is not application/json
3 participants