-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix http response header (#2924) #2925
Conversation
Signed-off-by: logeable <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2925 +/- ##
==========================================
+ Coverage 95.91% 95.97% +0.06%
==========================================
Files 223 223
Lines 9708 9708
==========================================
+ Hits 9311 9317 +6
+ Misses 327 324 -3
+ Partials 70 67 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
In the future, please add Resolve #1234
to the description to link & close the respective ticket.
@Ashmita152 this is an interesting example where many GH actions fail because the source branch of the fork is also master, and it's confusing the scripts into thinking they need to do Docker release as if it was on real master. |
@logeable do you mind re-creating this PR from a named branch in your fork? In general, I do not recommend doing PRs from master even in your own fork, it's best to keep master in sync with upstream. |
Thanks for reminding. |
Ok, I'll create a new pr. |
Which problem is this PR solving?
Short description of the changes